Initial mailer component docs #11626
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
requested changes
May 30, 2019
components/mailer.rst
Outdated
| Async | ||
| ----- | ||
|
|
||
| If you want to use the async functionality you need to install `messenger` component. |
There was a problem hiding this comment.
Suggested change
| If you want to use the async functionality you need to install `messenger` component. | |
| If you want to use the async functionality you need to install the ``messenger`` component. |
There was a problem hiding this comment.
Even better, link to the docs of the component via :doc:.....
|
@weaverryan I have made the changes as per the request. Some additional changes are added as mentioned on the previous comments. |
wouterj
reviewed
May 30, 2019
|
Thank you @wouterj for providing more information. I have in-corporated the changes as per your request. |
harikt
commented
May 31, 2019
weaverryan
added a commit
that referenced
this pull request
May 31, 2019
This PR was merged into the 4.3 branch. Discussion ---------- The Mailer Documentation o/ friends! Say hello to the Mailer documentation (#11626 does the component). A lot of the docs were moved from the mime component, and pretty much everything here was tested. Reviews, questions and comments are warmly welcomed. Note: the first commit was just to "deprecate" the Swift Mailer docs and copy the `email/*` docs into the one, deprecated Swift Mailer document (`email.rst`). Mailer lives in `mailer.rst`. Cheers! Commits ------- c2e92a5 deprecating Swift Mailer and moving all docs into one spot and moving many docs from mime to Mailer and writing it
|
Hi @weaverryan , Any reason this PR need to wait ? |
|
Hey @harikt , I bet this is going to be merged soon, could you reopen this PR and wait a bit more, please? |
|
I agree - reopening - we’re just a little slow at times - sorry! |
weaverryan
requested changes
Aug 1, 2019
Co-Authored-By: Antoine Makdessi <antoine.makdessi@agriconomie.com>
Co-Authored-By: Ryan Weaver <weaverryan+github@gmail.com>
|
Requested changes has been incorporated. |
|
Thank you @harikt! |
|
You are welcome @weaverryan . Thank you for taking your valuable time to merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I am trying to make an attempt fix #11531 and move the mailer component doc forward.
I have not heard, the talk by @fabpot . This is not a polished version, but may be something to move on / fix.
Thank you.